Enable multithreaded compilation for ps2EntryRunner with MSVC /MP flag#84
Enable multithreaded compilation for ps2EntryRunner with MSVC /MP flag#84PlasteredCrab wants to merge 1 commit intoran-j:mainfrom
Conversation
|
I'd suggest using /MP4 flag to limit number of processes. At least in weaker machines like what I use, /MP (which uses all available processes) and other similar flags is too resource intensive and will block other unrelated OS operations causing freezing |
PlasteredCrab
force-pushed
the
feature/ps2entryrunner-multithreading
branch
from
8cd6475 to
60e214f
Compare
|
|
||
| if(MSVC) | ||
| target_compile_options(ps2EntryRunner PRIVATE /FS) | ||
| target_compile_options(ps2EntryRunner PRIVATE /FS /MP4) |
There was a problem hiding this comment.
Ok we have 2 problems here.
First is a hardcode 4. My pc has like 12 cores so using 4 will be ass for me.
You are only applying this to msvc but a lot of people use other compilers
There was a problem hiding this comment.
Ah sorry Edgar told me 4 would be better for weaker PCs haha. A command argument to specify the amount of cores or max cores was suggested as well which we could do instead!
|
I think this is more of personal usage but ok. I will merge @PlasteredCrab just move the flag to be applied to all.compilers not only msvc |
3 participants
Add Multithreading for Building with /MP flag.
Tested this and it builds much faster